On Wed, 8 Jul 2020 10:07:13 +0800 Lu Baolu <baolu...@linux.intel.com> wrote:
> Hi, > > On 7/8/20 7:43 AM, Jacob Pan wrote: > > +For UAPIs that are shared with in-kernel users, a wrapper function > > +is provided to distinguish the callers. For example, > > + > > +Userspace caller :: > > + > > + int iommu_sva_unbind_gpasid(struct iommu_domain *domain, struct > > device *dev, > > + void __user *udata) > > + > > +In-kernel caller :: > > + > > + int __iommu_sva_unbind_gpasid(struct iommu_domain *domain, > > struct device *dev, > > + struct iommu_gpasid_bind_data *data) > > iommu_page_response() may have the same needs. Can we reach an > agreement on the naming rules? > Yes iommu_page_response() also has to deal with in-kernel and UAPI callers. I left it out because I thought the current VFIO and SVA common code is not ready for PRQ yet, I might be reading old news :) argsz need to be handled as well. Perhaps we can wait until this set is settled? Do you have a suggestion on the naming rules? > Best regards, > baolu [Jacob Pan] _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu