On Tue, Jun 2, 2020 at 10:30 PM Mika Westerberg
<mika.westerb...@intel.com> wrote:
>
> On Tue, Jun 02, 2020 at 04:26:02PM -0700, Rajat Jain wrote:
> > +static bool risky_device(struct pci_dev *pdev)
> > +{
> > + if (pdev->untrusted) {
> > + pci_warn(pdev,
> > + "Skipping IOMMU quirk for dev (%04X:%04X) on
> > untrusted"
> > + " PCI link. Please check with your BIOS/Platform"
> > + " vendor about this\n", pdev->vendor, pdev->device);
>
> You should not break user visible strings like this. It makes grepping
> for them harder (see also CodingStyle). You can write it like this instead:
>
> pci_info(pdev, "Skipping IOMMU quirk for dev (%04X:%04X) on untrusted
> PCI link\n",
> pdev->vendor, pdev->device);
> pci_info(pdev, "Please check with your BIOS/Platform vendor about
> this\n");
>
> Also I guess pci_info() might be better here after all. Your call :)
Done, sent the updated patch.
Thanks,
Rajat
>
> Rest of the patch looks good to me.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
