On Sun Dec 08 19, Lu Baolu wrote:
Hi,
On 12/7/19 10:41 AM, Jerry Snitselaar wrote:
On Fri Dec 06 19, Jerry Snitselaar wrote:
On Sat Dec 07 19, Lu Baolu wrote:
Hi Jerry,
On 12/6/19 3:24 PM, Jerry Snitselaar wrote:
On Fri Dec 06 19, Lu Baolu wrote:
[snip]
Can you please try below change? Let's check whether the afending
address has been mapped for device 01.00.2.
$ git diff
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index db7bfd4f2d20..d9daf66be849 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -663,6 +663,8 @@ static int
iommu_group_create_direct_mappings(struct iommu_group
*group,
ret = iommu_map(domain, addr, addr,
pg_size, entry->prot);
if (ret)
goto out;
+
+ dev_info(dev, "Setting identity map
[0x%Lx - 0x%Lx] for group %d\n", addr, addr + pg_size,
group->id);
}
}
I am doubting that device 01.00.2 is not in the device scope of
[ 4.485108] DMAR: RMRR base: 0x000000bdf6f000 end: 0x000000bdf7efff
By the way, does device 01.00.2 works well after binding the driver?
When I boot it with passthrough it doesn't get to a point where I can
login. I think the serial console on these systems is tied to the ilo,
so the conserver connection could be making things
worse. Unfortunately the system is remote. I should have more time now
to focus on debugging this.
Attaching console output for the above patch.
It seems that device 01.00.2 isn't in the scope of RMRR [base:
0x000000bdf6f000 end: 0x000000bdf7efff]. But it still tries to access
the address within it, hence faults generated.
You can check it with ACPI/DMAR table.
Best regards,
baolu
I believe it is the 3rd endpoint device entry in dmar data below.
So question about request_default_domain_for_dev. Since a dma mapping
is already done for 1.00.0, and that sets the default_domain for the
group (I think), won't it bail out for 1.00.2 at this check?
if (group->default_domain && group->default_domain->type == type)
goto out;
Or I guess request_default_domain_for_dev wouldn't even be called
for 1.00.2.
intel_iommu_add_device it wouldn't even call one of the request
functions with 1.00.2 since domain->type would be dma from 1.00.0,
and device_def_domain_type
should return dma.
Can you please add some debug messages and check what really happens
here?
Best regards,
baolu
[ 25.000544] pci 0000:01:00.0: Adding to iommu group 25
[ 25.502243] pci 0000:01:00.0: DMAR: domain->type is identity <<
intel_iommu_add_device (alloced in iommu_group_get_for_dev)
[ 25.504239] pci 0000:01:00.0: DMAR: device default domain type is dma. requesting
dma domain << intel_iommu_add_device
[ 25.507954] pci 0000:01:00.0: Using iommu dma mapping <<
request_default_domain_for_dev (now default domain for group is dma)
[ 25.509765] pci 0000:01:00.1: Adding to iommu group 25
[ 25.511514] pci 0000:01:00.1: DMAR: domain->type is dma <<
intel_iommu_add_device
[ 25.513263] pci 0000:01:00.1: DMAR: device default domain type is identity.
requesting identity domain << intel_iommu_add_device
[ 25.516435] pci 0000:01:00.1: don't change mappings of existing devices.
<< request_default_domain_for_dev
[ 25.518669] pci 0000:01:00.1: DMAR: Device uses a private identity domain.
<< intel_iommu_add_device
[ 25.521061] pci 0000:01:00.2: Adding to iommu group 25
[ 25.522791] pci 0000:01:00.2: DMAR: domain->type is dma <<
intel_iommu_add_device
[ 25.524706] pci 0000:01:00.4: Adding to iommu group 25
[ 25.526458] pci 0000:01:00.4: DMAR: domain->type is dma <<
intel_iommu_add_device
[ 25.528213] pci 0000:01:00.4: DMAR: device default domain type is identity.
requesting identity domain << intel_iommu_add_device
[ 25.531284] pci 0000:01:00.4: don't change mappings of existing devices.
<< request_default_domain_for_dev
[ 25.533500] pci 0000:01:00.4: DMAR: Device uses a private identity domain.
<< intel_iommu_add_device
So the domain type is dma after 01:00.0 gets added, and when
intel_iommu_add_device is called for 01:00.2 it will go into the if
section. Since the device default domain type for 01:00.2 is dma
nothing happens in there, and it goes on to 01:00.4. Is the "private
identity domain" message really accurate since everyone will use
si_domain? Adding some more debugging.
Regards,
Jerry
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
