On Wed, 2017-02-22 at 12:26 +0100, Joerg Roedel wrote: > Hi Andy, > > On Wed, Feb 15, 2017 at 04:42:21PM +0200, Andy Shevchenko wrote: > > By default CONFIG_INTEL_IOMMU_DEFAULT_ON is not set and thus > > dmar_disabled variable is set. > > > > Intel IOMMU driver based on above doesn't set intel_iommu_enabled > > variable. > > > > The commit b0119e870837 ("iommu: Introduce new 'struct > > iommu_device'") > > mistakenly assumes it never happens and tries to unregister not ever > > registered resources, which crashes the kernel at boot time: > > > > BUG: unable to handle kernel NULL pointer dereference at > > 0000000000000008 > > IP: iommu_device_unregister+0x31/0x60 > > > > Make unregister procedure conditional in free_iommu(). > > > > Fixes: b0119e870837 ("iommu: Introduce new 'struct iommu_device'") > > Cc: Joerg Roedel <jroe...@suse.de> > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > > Thanks for the patch, I applied it and will send it upstream asap.
Thanks! Any comments on the rest? I would like to send v2. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu