Hi,

> just a question,
>
>>>     pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
>>> -   if (IS_ERR(pdev))
>>> -           return PTR_ERR(pdev);
>>> +   if (!pdev)
>>> +           return -ENOMEM;
>>>  
>>>     /*
>>>      * use the first registered sysmmu device for performing
>>>
> is ENOMEM the right return value? of_platform_device_create()
> doesn't fail only in case of malloc failure.
>
> Shouldn't it be ENODEV instead, which might also mean with some
> imagination that there is no memory available for that device?
>
Your are right, I will change the error to -ENODEV and resend the patch.

Thanks,
Wei Yongjun




_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to