On Tue, 28 Jun 2016 20:40:37 +0200 Heiner Kallweit <hkallwe...@gmail.com> wrote:
> The init function ensures that iommu_group_kset can't be NULL. > Therefore this check isn't needed. Have you seen your previous patch? Wasn't this claim that the init function ensures iommu_group_kset more true when iommu_init() called BUG_ON(!iommu_group_kset) than it is when we can get by with just returning -ENOMEM? Thanks, Alex > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > --- > drivers/iommu/iommu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index b36ec9c..b36e24d 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -235,9 +235,6 @@ struct iommu_group *iommu_group_get_by_id(int id) > struct iommu_group *group; > const char *name; > > - if (!iommu_group_kset) > - return NULL; > - > name = kasprintf(GFP_KERNEL, "%d", id); > if (!name) > return NULL; _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
