On 27/01/16 05:21, Anup Patel wrote:
We are saving pointer to iommu DT node in of_iommu_set_ops()
hence we should increment DT node ref count.

Oh man, shame on whoever wrote that code! :P

Reviewed-by: Robin Murphy <robin.mur...@arm.com>

Signed-off-by: Anup Patel <anup.pa...@broadcom.com>
Reviewed-by: Ray Jui <r...@broadcom.com>
Reviewed-by: Scott Branden <sbran...@broadcom.com>
---
  drivers/iommu/of_iommu.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 60ba238..5fea665 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct 
iommu_ops *ops)
        if (WARN_ON(!iommu))
                return;

+       of_node_get(np);
        INIT_LIST_HEAD(&iommu->list);
        iommu->np = np;
        iommu->ops = ops;


_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to