Hi Laurent, > > On Monday 20 July 2015 17:33:24 Suman Anna wrote: >> The OMAP IOMMU driver has been adapted to the IOMMU framework >> for a while now, and it does not support being built as a >> module anymore. So, remove all the module references from the >> OMAP IOMMU driver. >> >> While at it, also relocate a comment around the subsys_initcall >> to avoid a checkpatch strict warning about using a blank line >> after function/struct/union/enum declarations. >> >> Signed-off-by: Suman Anna <s-a...@ti.com> > > I think this is one of the checkpatch warnings that can be safely ignored, > but > it doesn't matter much. The comment will be removed after the OMAP3 ISP and > OMAP IOMMU drivers get support for a saner IOMMU probing dependency order > solution. > > The code seems fine to me. > > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Yes, indeed. I have also started to work on some patches to switch to using the IOMMU_OF_DECLARE init, that should also help us. I will post those for the 4.4 kernel merge window. regards Suman _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
