Hi Joerg, Am Montag, 29. Juni 2015, 16:06:37 schrieb Joerg Roedel: > On Mon, Jun 29, 2015 at 11:28:40AM +0200, Heiko Stübner wrote: > > The Rockchip iommu uses bus_set_ops to set its iommu-ops for the platform > > bus and currently returns -ENODEV if it encounters a platform_devices that > > does not have an iommu. As add_iommu_group ignored these returns > > till now this worked, but of course starts to fail now. > > > > All two invocations of the add_device callback ignored (or still ignore) > > the return value so I've come with the following small patch to fix the > > breakage that now exists in the 4.2 tree. > > > > There is probably a better solution possible in the longer term, likely > > similar to what Samsung does, but I'm not sure yet how this would work > > with our drm device that needs an iommu mapping without having an > > iommu (the iommus being attached to the crtc-components). > > Btw, if you want to test the fix too, here is the link: > > http://lists.linuxfoundation.org/pipermail/iommu/2015-June/013508.html
yep, works like a charm and fixes the issue. So if helpful: Tested-by: Heiko Stuebner <he...@sntech.de> Thanks Heiko _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
