> -----Original Message----- > From: H. Peter Anvin [mailto:h...@zytor.com] > Sent: Saturday, January 31, 2015 2:19 AM > To: Wu, Feng; t...@linutronix.de; mi...@redhat.com; x...@kernel.org; > g...@kernel.org; pbonz...@redhat.com; dw...@infradead.org; > j...@8bytes.org; alex.william...@redhat.com; jiang....@linux.intel.com > Cc: eric.au...@linaro.org; linux-ker...@vger.kernel.org; > iommu@lists.linux-foundation.org; k...@vger.kernel.org > Subject: Re: [v3 21/26] x86, irq: Define a global vector for VT-d > Posted-Interrupts > > On 12/12/2014 07:14 AM, Feng Wu wrote: > > Currently, we use a global vector as the Posted-Interrupts > > Notification Event for all the vCPUs in the system. We need > > to introduce another global vector for VT-d Posted-Interrtups, > > which will be used to wakeup the sleep vCPU when an external > > interrupt from a direct-assigned device happens for that vCPU. > > > > Signed-off-by: Feng Wu <feng...@intel.com> > > > > > #ifdef CONFIG_HAVE_KVM > > +void (*wakeup_handler_callback)(void) = NULL; > > +EXPORT_SYMBOL_GPL(wakeup_handler_callback); > > + > > Stylistic nitpick: we generally don't explicitly initialize > global/static pointer variables to NULL (that happens automatically anyway.) > > Other than that, > > Acked-by: H. Peter Anvin <h...@linux.intel.com>
Thanks a lot for your review, Peter! Thanks, Feng _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
