> -----Original Message-----
> From: Emil Medve [mailto:emilian.me...@freescale.com]
> Sent: Wednesday, January 28, 2015 8:05 PM
> To: iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de;
> Sethi Varun-B16395
> Cc: Medve Emilian-EMMEDVE1
> Subject: [PATCH 10/26] iommu/fsl: Fix checkpatch type
> ALLOC_WITH_MULTIPLY
> 
> WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply
> +               dma_domain->win_arr = kzalloc(sizeof(*dma_domain->win_arr) *
> +                                                         w_count,
> + GFP_ATOMIC);
> 
> Signed-off-by: Emil Medve <emilian.me...@freescale.com>
> ---
>  drivers/iommu/fsl_pamu_domain.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/fsl_pamu_domain.c
> b/drivers/iommu/fsl_pamu_domain.c index 9417207..dcb9bb4 100644
> --- a/drivers/iommu/fsl_pamu_domain.c
> +++ b/drivers/iommu/fsl_pamu_domain.c
> @@ -1037,8 +1037,9 @@ static int fsl_pamu_set_windows(struct
> iommu_domain *domain, u32 w_count)
>                               ((w_count > 1) ? w_count : 0));
>       if (!ret) {
>               kfree(dma_domain->win_arr);
> -             dma_domain->win_arr = kzalloc(sizeof(*dma_domain-
> >win_arr) *
> -                                                       w_count,
> GFP_ATOMIC);
> +             dma_domain->win_arr = kcalloc(w_count,
> +                                           sizeof(*dma_domain->win_arr),
> +                                           GFP_ATOMIC);
>               if (!dma_domain->win_arr) {
>                       spin_unlock_irqrestore(&dma_domain-
> >domain_lock, flags);
>                       return -ENOMEM;
> --
> 2.2.2
Acked-by: Varun Sethi <varun.se...@freescale.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to