Hi Geert, On Monday 15 December 2014 14:07:52 Geert Uytterhoeven wrote: > On Mon, Dec 15, 2014 at 1:13 AM, Laurent Pinchart wrote: > > Add the seven IPMMU instances found in the r8a7791 to DT with a disabled > > status. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+rene...@ideasonboard.com> > > The addresses and interrupt numbers look OK to me. > However, my comment about the "0x800" offset is still valid. > Shouldn't we have two register blocks, and let the driver use only the > second one? > > If you ignore, feel free to add my > Acked-by: Geert Uytterhoeven <geert+rene...@glider.be>
I don't want to ignore your comment, but I don't know what to do here :-/ The datasheet lacks detailed information about secure vs. non-secure mode and how the two register sets are supposed to interoperate and be handled by the operating system. -- Regards, Laurent Pinchart _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
