> -----Original Message----- > From: Joerg Roedel [mailto:j...@8bytes.org] > Sent: Thursday, September 04, 2014 3:44 PM > To: Sethi Varun-B16395 > Cc: iommu@lists.linux-foundation.org; alex.william...@redhat.com; Medve > Emilian-EMMEDVE1; linuxppc-...@ozlabs.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] iommu/fsl: Fix warning resulting from adding PCI device > twice > > On Thu, Sep 04, 2014 at 11:33:42AM +0530, Varun Sethi wrote: > > + if (!iommu_group_get(dev)) > > + ret = iommu_group_add_device(group, dev); > > > > iommu_group_put(group); > > return ret; > > Doesn't this additional call to iommu_group_get take a reference to the > iommu_group that needs to be released? Yes, you are right this would take a reference to the group that should be released. I need to add iommu_group_put for decrementing the reference count. Will post a new patch.
Thanks, Varun _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
