On Tue, Jul 29, 2014 at 12:48:05AM +0100, Mitchel Humpherys wrote:
> On Mon, Jul 28 2014 at 12:03:27 PM, Will Deacon <will.dea...@arm.com> wrote:
> >> @@ -1203,12 +1190,22 @@ static int arm_smmu_attach_dev(struct iommu_domain
> >> *domain, struct device *dev)
> >> }
> >> spin_unlock_irqrestore(&smmu_domain->lock, flags);
> >>
> >> + irq = smmu->irqs[smmu->num_global_irqs + cfg->irptndx];
> >> + ret = request_irq(irq, arm_smmu_context_fault, IRQF_SHARED,
> >> + "arm-smmu-context-fault", domain);
> >> + if (IS_ERR_VALUE(ret)) {
> >> + dev_err(smmu->dev, "failed to request context IRQ %d (%u)\n",
> >> + cfg->irptndx, irq);
> >> + cfg->irptndx = INVALID_IRPTNDX;
> >> + return ret;
> >> + }
> >
> > This changes the driver behaviour, so we'll request an IRQ for the domain
> > *every* time a master is successfuly added to the domain, as opposed to
> > the first time a master is added (when we can do the lazy init).
>
> Woops, you're absolutely right. Good catch.
>
> >
> > Maybe we could rework the code so that it looks like:
> >
> > dom_smmu = ACCESS_ONCE(&smmu_domain->smmu);
>
> Why do we need an ACCESS_ONCE here? I thought the purpose of ACCESS_ONCE
> was to prevent the compiler from optimizing away the access (like a
> variable being pulled out of a for-loop because it's not modified within
> the loop (but could be modified on another thread)), but since we
> haven't accessed smmu_domain->smmu before this point and your proposed
> re-check below will be on the other side of a spinlock how could the
> compiler optimize it away?
The issue is that we have a reader and a writer for the smmu pointer
operating concurrently. For that to work, we need single-copy atomicity
and we also need to suppress some GCC optimisations (for example, the case
where it can move an assignment clause from an else block before the if).
In this case, we're probably alright but I think we should keep this
ACCESS_ONCE and also add one to arm_smmu_init_domain_context on the
assignment side.
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
