On Mon, 2014-04-14 at 21:40 +0000, Woodhouse, David wrote:
> On Mon, 2014-04-14 at 15:22 -0600, Alex Williamson wrote:
> > 
> > > +             if (dev_tmp) {
> > > +                     if (pci_is_pcie(dev_tmp)) {
> > > +                             bridge_bus = dev_tmp->subordinate->number;
> > > +                             bridge_devfn = 0;
> > > +                     } else {
> > > +                             bridge_bus = dev_tmp->bus->number;
> > > +                             bridge_devfn = dev_tmp->devfn;
> > > +                     }
> > > +                     spin_lock_irqsave(&device_domain_lock, flags);
> > > +                     info = dmar_search_domain_by_dev_info(segment, bus, 
> > > devfn);
> > 
> > 
> > bus and devfn are uninitialized here, CID 1197747 & 1197746.  Thanks,
> 
> Oops. That should be using bridge_bus and bridge_devfn, shouldn't it?
> 
> Will fix; thanks.
> 

Yep, I think it was supposed to be bridge_*.  Thanks,

Alex

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to