Hi Chris,

Chris Wright <chr...@sous-sol.org> wrote @ Tue, 26 Jun 2012 20:15:55 +0200:

> This looks buggy to me:
> 
> drivers/iommu/tegra-smmu.c::smmu_iommu_domain_init()
> 
>   spin_lock_irqsave(&tmp->lock, flags);   <-- lock held, interrupts off
>   alloc_pdir(as = tmp)
>     devm_kzalloc(..., GFP_KERNEL);        <-- potentially sleeping allocation
>     ...
>     alloc_page(..., GFP_KERNEL | __GFP_DMA);   <-- same here

Right. I totally agree. Thank you for pointing this out.

The fix patch follows.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to