On Tue, Mar 13, 2012 at 7:00 PM, Joerg Roedel <[email protected]> wrote: > On Tue, Mar 13, 2012 at 05:50:16PM +0900, KyongHo Cho wrote: >> >> +struct sysmmu_drvdata { >> >> + struct device *sysmmu; >> >> + char *dbgname; >> >> + int nsfrs; >> >> + void __iomem **sfrbases; >> >> + struct clk *clk[2]; >> >> + int activations; >> >> + rwlock_t lock; >> >> + struct iommu_domain *domain; >> >> + sysmmu_fault_handler_t fault_handler; >> >> + unsigned long pgtable; >> >> + struct iommu_client client; >> >> +}; >> > >> > Is there any reason why 'struct iommu_client' is a seperate data >> > structure? Otherwise it can be merged with 'truct sysmmu_drvdata'. > > Of course this doesn't need to be changed immediatly. I just asked if > there was a specific reason for this seperation. > >> The problems will be soon fixed and I will post next patch tomorrow. > > Fine. Please also get the Acked-bys from the Exynos maintainer on > patches 1 and 2 at least. I'll merge it then. > Thank you. AFAIK, Exynos maintainer is somewhat busy for his own job. I will ask him to ack my patch soon.
Best regards, Cho KyongHo. _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
