Den 2019-09-26 kl. 10:06, skrev Nikita Popov:
On Tue, Sep 24, 2019 at 10:06 PM Sara Golemon <poll...@php.net> wrote:
On Tue, Sep 24, 2019 at 12:24 PM Claude Pache <claude.pa...@gmail.com>
wrote:
The choice of supporting precisely the two literal values `null` and
`false`
is not arbitrary: They are the two values that are the most often used as
sentinel values (for indicating failure or absence). It is true that
`true` is
also sometimes used as sentinel value (more rarely and not among the
internal functions), but the same can be said of other literal values
(one of your examples includes `0`).
While I personally think `false` makes sense as an allowed "type", I also
don't want to see the union types RFC get held up on such a tiny detail.
I would propose either of the following alternatives:
1/ Remove `false` from the proposal. It can always be added at a later
time, but not taken away.
2/ Make this detail a sub-vote. I would suggest that this sub-vote should
also be subject to a 2/3 majority in order to pass.
-Sara
This RFC is currently held up by a lack of implementation. Once that is
done, the RFC will go forward as-is (barring any novel concerns). Because I
consider it an important part of the overall proposal (*), I will neither
remove the false type, nor split it into a separate vote. People may vote
against the whole RFC if they disagree with this aspect, or any other
aspect of the proposal.
Regards,
Nikita
(*) While certainly not the primary reason for why we should support union
types, the reason why I brought this proposal forward at this time
specifically, is that the lack of union types is a blocker for my pet
project of providing comprehensive type annotations for internal functions.
Supporting "false" is strictly necessary for this purpose, because it is
part of nearly all unions as far as internal functions are concerned.
Hi Nikita,
Given the feedback on 23/9 from B Morel regarding
occurrence of true as a return value, would you then
consider adding true as a valid return type in unions?
r//Björn L
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
