Hi Benjamin, I like the proposal.
On Mon, 16 Sep 2019 at 01:40, Benjamin Eberlei <kont...@beberlei.de> wrote: > I am asking about feedback especially on the section "Implementation > Details", that explains some key differences to "PHPify" the DOM Living > Standard API to PHP and ext/dom. Do you have any comments about the > reasonability of the choices? > I don't have feedback, other than to ask what choices other languages have made when bringing in the DOM Living Standard API? > Also the section on "Not adopting Nodes for now" is new and I need some > feedback on this issue: To keep the proposal slim with respect to changing > existing behavior, the improved behavior of the DOM Living Standard over > Level 1-2 tof automatically adopting nodes instead of throwing a WRONG > DOCUMENT DOMexception is not considered for now. Do you think this is a > reasonable approach to go forward with? > If I understand correctly, the issue is the behaviour of a method has changed significantly. If not implemented in PHP 8, where BC breaks are expected, when would be a better time? Would deviating and implementing the new behaviour with a different method name e.g. appendAndAdoptChild(); or guarded by a version flag (so users choose whether they want the 'Living' behaviour or the 'Level 2' behaviour in this method) be options? Peter
