Hi Nicolas, pon., 12 sie 2019 o 10:17 Nicolas Grekas <nicolas.grekas+...@gmail.com> napisał(a):
> Le lun. 11 déc. 2017 à 14:44, Nikita Popov <nikita....@gmail.com> a écrit > : > > > Some time ago I introduced the following proposal for namespace-scoped > > declares: > > > > https://wiki.php.net/rfc/namespace_scoped_declares > > > > The idea is to allow specifying declare directives for a whole library or > > project using: > > > > namespace_declare('Vendor\Lib', ['strict_types' => 1]); > > > > I've finally gotten around to implementing this proposal ( > > https://github.com/php/php-src/pull/2972) and would like to move forward > > with it. > > > > The reason why I'm picking it up again is some feedback I received for > the > > explicit call-time send-by-ref proposal. The main objection seems to be > > that the feature has limited usefulness if it's optional rather than > > required, because you still can't be sure that something is a by-value > > pass, just because no & is present. At the same time, we can't make this > > required anytime soon due to the large BC impact. > > > > Namespace-scoped declares are perfectly suited to resolve this problem. > We > > can introduce a require_explicit_send_by_ref declare directive to make > the > > call-site annotation required, and libraries/projects can easily opt-in > to > > it using namespace_declare(). There would be no BC impact, while at the > > same time projects could benefit from the additional clarity and > > performance improvements immediately. > > > > I've read discussions about the notion of a "package" and the way we should > define its boundaries. > What about the following? > > Individual files could declare their package using this style: > <?php declare(package=MyVendor\MyPackage); > > That would be enough to group a set of files together and make them share > eg some private classes, some optional PHP behaviors, etc. > > Why suggesting use of declare for that? Wouldn't a new "package" keyword be more appropriate for that? For eg.: <?php package MyVendor\MyLib; I was also thinking about it to be a part of FQCN cause PHP would figure out package name from namespaced symbol names. Was even thinking about writing generic RFC for packages we could discuss on and redirect discussion into package related topic. > The right side "MyVendor\MyPackage" would also be a FQCN that PHP would > autoload as a regular class. The corresponding class would then be the > place where ppl would declare the engine behavior they want for their > package (strict types, etc). To enforce this, the engine could require that > the "MyPackage" class implements some interface/extend some base abstract > class. > > Of course, one could hijack a package and declare an unrelated file as part > of it, but I don't think that's an issue: the situation is the same as for > namespaces, where one can hijack a third party vendor namespace. In > practice, it proved not being an issue, and the original author's intent is > clear: "this is my namespace/package, if you mess with it, fine, but you're > on your own". > > Nicolas > -- regards / pozdrawiam, -- Michał Brzuchalski about.me/brzuchal brzuchalski.com
