On 15.05.2019 at 19:14, Robert Kopack wrote: > I would to extend the functionality of the current sqlite3 implementation > (in *ext/sqlite3* and in *ext/pdo_sqlite*) by exposing the functions > related to extended result codes. I have already forked and made my changes > at > https://github.com/rkopack/php-src/commit/f6c4d1eeccd27a3c5bd836fd8205b1283bd5eabc. > From > my understanding Scott MacVicar and Christoph M. Becker are the primary > maintainers for the sqlite3 extension and Ilia Alshanetsky is the primary > maintainer for the pdo_sqlite extension;
It's best to look at EXTENSIONS in master[1], which also reveals the most up-to-date dates of maintainership – i.e. pdo_sqlite is effectively maintained by the core maintainers. > if any of you would like to > comment on this (it's around 50 lines of new code) so I can get feedback on > this I would greatly appreciate it. I made sure to follow the convention I > saw in the file(s) to the best of my ability but I am sure there are little > things I might have missed. I haven't reviewed closely for now, but basically I like these additions. With regard to sqlite3_extended_result_codes() we have to review existing error checks (they likely need small adjustments, if extended error codes are enabled). And we likely want to have a few tests for the new functionality. Feel free to submit a pull request[2]; it seems to me any discussion could happen on Github as well. :) [1] <https://github.com/php/php-src/blob/master/EXTENSIONS> [2] <https://github.com/php/php-src/pulls> Thanks, Christoph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
