On Fri, Apr 26, 2019 at 3:10 PM Benjamin Morel <benjamin.mo...@gmail.com> wrote:
> > Yes, PHP 8 for BCs and PHP 7.4 for warnings that's what I was trying to > said > > FWIW, I don't think anyone will complain about adding a warning to > something that's obviously a bug when it fails. > I'd say go ahead a write an RFC. If you want to have more chances for it to > pass though, I would not change the semantics of the current conversions > from string to decimal (what's considered a valid decimal number and what's > not). I would just propose to add a warning when an argument is converted > to zero because it is *currently* considered malformed. > > - Ben > Feel free to just send a PR that implements the warning. We don't really need an RFC for such a minor and straightforward change. Nikita
