On Sat, Mar 23, 2019 at 2:22 PM Lester Caine <les...@lsces.co.uk> wrote:
> On 23/03/2019 12:46, Kalle Sommer Nielsen wrote: > >> Now to get back to working out why Nikita's patch does not work in > >> 7.2.16 ... > > Obviously because the patch was made for PHP 7.3. Hint: If a > > macro/function is not available in 7.2, then look at how it is > > implemented in 7.3 and migrate it or see how other functions who do > > similar functionality works and port it. > > When merging the patch with the older code I was fairly sure that it did > exist already in 7.2 ... but until I can get php-src synced I'm having > to manually scan for this stuff ... at the current rate hg-git will take > 24 days so now I need another plan of attack :( > Why are you making it so complicated? php-src has a definition of the macros, its easy to look up on github.com/php/php-src, just copy this into the file that uses GC_ADDREF/DELREF above the usage: #ifndef GC_ADDREF #define GC_ADDREF(p) (GC_REFCOUNT(p)++) #endif #ifndef GC_DELREF #define GC_DELREF(p) (GC_REFCOUNT(p)--) #endif > -- > Lester Caine - G8HFL > ----------------------------- > Contact - https://lsces.co.uk/wiki/?page=contact > L.S.Caine Electronic Services - https://lsces.co.uk > EnquirySolve - https://enquirysolve.com/ > Model Engineers Digital Workshop - https://medw.co.uk > Rainbow Digital Media - https://rainbowdigitalmedia.co.uk > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >
