On Mon, Feb 4, 2019 at 9:00 AM Stanislav Malyshev <smalys...@gmail.com> wrote:
> Hi! > > >> I want to say that even a small and fairly > > simple code change, > > which I proposed to push through the bureaucracy, was difficult. > > We're discussing RFCs. Small and fairly simple code change does not need > an RFC. I think this is what Nikita wants to change with this simpler procedure. More RFCs even on smaller changes, so that more broad input can be gathered before doing any kind of change. > So either: > > a) this change is indeed small and simple, and does not belong to the > topic about RFC process, maybe about code review process, which is no > less important, but different talk. > > b) this change wasn't as small and simple as it appeared, it did require > the RFC, but you didn't know that. It's not your fault, no shame here - > but this shows the process worked as it should have. > > > This, I am afraid is all too common. Many many times, while working > through > > github issues, I will be uncomfortable with making a merge for someone > > without input from internals. I would tell that person to start a > > discussion on internals and they would be flat ignored, their change dead > > in the water, and their reason to continue contributing evaporates. > > But how this relates to RFCs? Certainly not every patch needs an RFC. > > -- > Stas Malyshev > smalys...@gmail.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >
