On Wed, Jan 23, 2019 at 7:08 AM Girgias <george.bany...@gmail.com> wrote:
> On Tue, 22 Jan 2019 at 22:52, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > >> Hi Girgias >> >> It seems good list in general. >> There would not be issues marking them as deprecated. >> "Deprecation" means "Soft deprecation", correct? >> >> Removing these aliases from PHP 8 is not good idea. >> Aliases should be removed when nobody cares about these aliases. >> >> For example, pg_loopen()/etc were there until nobody cares about these >> aliases. >> New names, pg_lo_open()/etc, were given in PHP4.x. These changes were >> documented since PHP 4.x. >> >> Regards, >> >> -- >> Yasuo Ohgaki >> yohg...@ohgaki.net >> > > Hello Yasuo Ohgaki. > > By Deprecation, I was indeed meaning that as of PHP 8 these function > should throw > E_DEPRECATED errors and be removed as of PHP 9 which would give plenty of > time > for people to adapt and upgrade their codebase. > This is good approach, too. The alias system does not allow to get currently called function name w/o overhead, AFAIK. i.e. It simply calls defined functions. Perhaps, add PHP_FALIAS_DEPRECATED() for it. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net
