On Thursday, September 13, 2018 at 7:30 AM Christoph M. Becker <cmbecke...@gmx.de> wrote:
>> Ironically, the League/Csv library uses `fputcsv()` behind the scenes, >> and thus suffers from the same escape character problem >> (see https://github.com/thephpleague/csv/issues/307). >> >> Is there any chance `fputcsv()` can be updated to allow setting a blank >> string as the escape character? As Christopher pointed out, this would >> not be a BC break, and while it wouldn't fix every issue with the >> function it would still be a step forward. Frankly I found it very >> surprising that the function *didn't* support passing a blank string. > > I've submitted <https://github.com/php/php-src/pull/3515>. Thanks so much for your work on this! Do you know if the patch can be included in PHP 7.3? If the patch was also applied to PHP 7.2 and 7.1, we wouldn't need to add fallback code in the League/Csv library for these versions. I understand if this isn't possible, but I'm trying to figure out how best to approach fixing the issue in League/Csv. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
