On Wed, 8 Aug 2018, Gabriel Caruso wrote: > Commit: 953e28a92c35b81f768ae08451f6e9da6b168e51 > Author: Gabriel Caruso <carusogabrie...@gmail.com> Sun, 5 Aug 2018 > 20:18:02 -0300 > Parents: f47cdd1ee0246b1d594de9ec29ce12c5279bc421 > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=953e28a92c35b81f768ae08451f6e9da6b168e51 > > Log: > Remove more unecessaries percent signs
I don't think you should be doing this. cheers, Derick > Follwing dae65a89 > > Changed paths: > M ext/zip/php_zip.c > > > Diff: > diff --git a/ext/zip/php_zip.c b/ext/zip/php_zip.c > index 4fedaba..09a7d3a 100644 > --- a/ext/zip/php_zip.c > +++ b/ext/zip/php_zip.c > @@ -1030,7 +1030,7 @@ static void php_zip_object_free_storage(zend_object > *object) /* {{{ */ > if (intern->za) { > if (zip_close(intern->za) != 0) { > #if LIBZIP_VERSION_MAJOR == 1 && LIBZIP_VERSION_MINOR == 3 && > LIBZIP_VERSION_MICRO == 1 > - php_error_docref(NULL, E_WARNING, "Cannot destroy the > zip context: %s", "zip_close have failed"); > + php_error_docref(NULL, E_WARNING, "Cannot destroy the > zip context: zip_close have failed"); > #else > php_error_docref(NULL, E_WARNING, "Cannot destroy the > zip context: %s", zip_strerror(intern->za)); > zip_discard(intern->za); > @@ -1543,7 +1543,7 @@ static ZIPARCHIVE_METHOD(close) > > if ((err = zip_close(intern))) { > #if LIBZIP_VERSION_MAJOR == 1 && LIBZIP_VERSION_MINOR == 3 && > LIBZIP_VERSION_MICRO == 1 > - php_error_docref(NULL, E_WARNING, "%s", "zip_close have > failed"); > + php_error_docref(NULL, E_WARNING, "zip_close have failed"); > #else > php_error_docref(NULL, E_WARNING, "%s", zip_strerror(intern)); > zip_discard(intern); > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > -- https://derickrethans.nl | https://xdebug.org | https://dram.io Like Xdebug? Consider a donation: https://xdebug.org/donate.php, or become my Patron: https://www.patreon.com/derickr twitter: @derickr and @xdebug -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php