On Fri, Jul 6, 2018 at 3:38 PM, Christoph M. Becker <cmbecke...@gmx.de> wrote:
> Hi! > > While trying to put together a patch to make PECL/uopz compatible with > PHP 7.3[1], I've stumbled upon commit ca035f2[2] and commit 1a63fa6[3]. > The former removed Z_CACHE_SLOT and related stuff, but the latter > reintroduced it with an apparently somewhat different meaning. If that > is correct, this change should be documented in UPGRADING.INTERNALS, and > perhaps it might even be better to rename the RECV_INIT cache and the > related macros, so any extension (probably few, if any) would already > fail at compile time. > > Thanks! > > [1] <https://github.com/krakjoe/uopz/issues/79> > [2] > <http://git.php.net/?p=php-src.git;a=commit;h= > ca035f26aa296acf553f289e2d459fd052367db2> > [3] > <http://git.php.net/?p=php-src.git;a=commit;h= > 1a63fa6ec9b0bacbb726e60c3c212e7d97b518c6> > The meaning of Z_CACHE_SLOT is still the same (cache slot stored in u2 of literal). The thing that changed is that we now prefer storing the cache slot directly on the opline, if possible. RECV_INIT is one of the cases where two independent cache slots are needed, one is stored on the opline and the other in Z_CACHE_SLOT of the initializer expression literal. Nikita
