> -----Original Message----- > From: Christoph M. Becker [mailto:cmbecke...@gmx.de] > Sent: Wednesday, July 4, 2018 8:00 PM > To: Zeev Suraski <vsura...@gmail.com>; Nikita Popov <nikita....@gmail.com> > Cc: Stanislav Malyshev <smalys...@gmail.com>; Internals > <internals@lists.php.net> > Subject: Re: [PHP-DEV] [RFC] Deprecate and remove case-insensitive constants > > On 04.07.2018 at 17:02, Zeev Suraski wrote: > > > On Wed, Jul 4, 2018 at 5:12 PM Nikita Popov <nikita....@gmail.com> wrote: > > > >> On Mon, Jun 25, 2018 at 8:03 AM, Stanislav Malyshev > >> <smalys...@gmail.com> > >> wrote: > >> > >> Are there any other opinions on this topic or the RFC in general? I'm > >> a bit surprised that there are so little comments after the somewhat > >> explosive discussion last time around. > > > > Personally I think that the grounds for deprecating this particular > > feature isn't very strong. Yes, we'd probably not do it this way if we > > were starting from scratch, but is it that bad for us to make the > > migration to PHP 8 a bit more difficult? I'm not sure. So I'm > > probably -1 on it, but at the same time I don't think it's bad enough > > to warrant active 'campaigning' against this RFC :) > > In my humble opinion, the listed motivations[1] are more than sufficient to > get > rid of this supposedly rarely used feature.
Fair enough, I disagree (after of course having read the motivations) but again don't feel that strongly about it. Realistically case insensitive constants are likely only used for global constants and not namespaced ones (namespaced code tends to go along with a more modern syntax guidelines). So I think the first issue is probably mostly theoretical, the 2nd one is a fairly minor annoyance IMHO, and the performance impact is likely negligible in the grand scheme of things. Not a huge bang for the buck in my humble opinion. Zeev
