On Sat, Nov 18, 2017 at 10:17 AM, Sara Golemon <p...@golemon.com> wrote:
> https://3v4l.org/kRON7 > > https://github.com/php/php-src/commit/f00d1c72b4dbaf3532569d20efc1da > 7c408605d6 > > The above patch optimizes calls to gettype() into an opcode, however the > strings returned for closed resources has changed relative to 7.1 and > earlier. > > The newer output is objectively better, but it's technically a BC break. > > Was this intentional, and are we fine letting this change stand? > > -Sara This is unrelated to the linked optimizations: The change was introduced in https://github.com/php/php-src/commit/34824b70f8e72b200d77957145bb61883b03322d and discussed as part of https://externals.io/message/94434. Another change from the same thread is that is_object() now returns true for all objects, including those of incomplete classes. Nikita
