On Sat, Oct 28, 2017 at 7:59 AM, Nikita Popov <nikita....@gmail.com> wrote:
> Right now we do not have a consistent standard for the indentation of
> PHPT files.
>
> I would like to propose that we establish a common standard
>
Not for nothin', but PSR-2 exists.  If we adopt *any* standard, I
think it should be this one* (which is a spiritual successor to PEAR's
CS fwiw).

> +1 but it needs to be done in the lowest active branch
> otherwise it will result in conflicts when changing
> existing tests (it is sometimes useful for extending tests)...
>
I'm not convinced that test files are in such an active state of churn
that this would net us much benefit for the cost.

-Sara

* PSR-12 is in the works as an update to PSR-2, but the items it
addresses are largely orthogonal to the kind of code you find in PHPT
files.

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to