Hi Dan, On 12/10/2017 14:06, Dan Ackroyd wrote: > If we add more magic methods to PDO, that are only present when the > connection was made to an SQLite DB, then there will be more mess to > cleanup, and more people are likely to complain about BC breaks, > if/when we refactor the features to not have shitty magic behaviour.
Since no one is planning to do such refactoring anytime soon, I see no reason to block any attempt to add driver-specific methods (i.e. features that only belong to a specific driver) until further notice. Whoever chooses to use them knows already their code is not portable to other drivers anyway. I have added a few PDO::pgsql* ones myself and feel no shame ;) > People have suggested changing the RFC process to require 2/3 approval > for all RFCs. This RFC is a prime example of why that might be needed. > We shouldn't be approving changes that are just barely good enough to > be included. Changes should be clearly the right choice, to be > included. I agree with the 2/3 boundary, but this specific RFC follows PDO's current standards. The fact that they are suboptimal to me is out of scope. Sill, I hope that proper LOB field type support lands in PDO_sqlite as well soon after. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
