On Thu, Oct 5, 2017 at 8:50 AM, Johannes Schlüter <johan...@schlueters.de> wrote: > I would prefer not exporting the php_gmp.h, but a gmp.h (or similar) > and let php_gmp.h there for main/builtin_functions.c only. If a > consumer wants access to the module_entry they can query EG(modules) > and other declarations in there should be "private". > Yeah, I shouldn't be lazy. I should do things right.
On Wed, Oct 4, 2017 at 5:32 PM, Kalle Sommer Nielsen <ka...@php.net> wrote: > +1, only note I have is that with the change to config.m4, a relevant > one should maybe also follow for phpize on Windows for config.w32 > Ugh, windows... is that still a thing? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
