On Tue, Jul 11, 2017 at 12:21 PM, Nikita Popov <nikita....@gmail.com> wrote:
> On Tue, Jul 11, 2017 at 11:52 AM, Marco Pivetta <ocram...@gmail.com> > wrote: > > > Asking here, since it's not clear to me: is this a good/fitting > > replacement for `spl_object_hash()`? > > > > On 11 Jul 2017 7:00 AM, "tyson andre" <tysonandre...@hotmail.com> wrote: > > > >> >> How long should I wait to see if there are objections before creating > >> a pull request? > >> >AFAIK you can create PR any time. > >> > >> I created a PR implementing spl_object_id(object $o) : int several days > >> ago, > >> at https://github.com/php/php-src/pull/2611 > >> -- > >> PHP Internals - PHP Runtime Development Mailing List > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > >> > Yes. spl_object_id() provides the same guarantees as spl_object_hash() -- > but is much faster and has a more compact output (an integer instead of an > iirc 32 byte string). > Just to clarify, that means object ids are still re-used between objects if one gets destroyed? The initial bug report was about creating a second function that solves this problem. > > Nikita >
