On Mon, Jun 26, 2017 at 11:45 AM, Andreas Heigl <andr...@heigl.org> wrote:
> Hi Côme. > > > Am 26.06.17 um 11:34 schrieb Côme Chilliet: > > Hello, > > > > Some time ago, someone said on the tracker that there was an up to date > patch for php-ldap exop and controls: https://bugs.php.net/bug.php? > id=69445 > > It appeared the code was in fact not up to date, at least not for PHP7. > > > > But it was enough to make me try again to work from there to add EXOP > support to PHP-LDAP, so I extracted the part about EXOP from the patch and > worked from there to have something working with current master. > > The result is there for now: https://github.com/MCMic/php- > src/tree/ldap_exop > > Thanks for that work! > > > > At least the methods for passwd and whoami EXOPs are working fine. > > > > Which PHP release should a change like that target? > > The first possible release IMHO would be PHP.Next (sadly…), as there's > already been a feature-freeze for PHP 7.2… > While that means that we have to wait another year until that feature > comes into production it also means that we might be able to have a more > conscise exop-handling for ldap by then… > > Do I need to open an RFC for these methods? > > As we add functionality to the language we should have one… shouldn't we? > I don't think it is necessary to have RFC for such specific functions. We added recently similar thing to OpenSSL (openssl_pkcs7_read) - similar in a way that probably only few people on this list care about it. :) The thing is that the RFC for such functionality usually won't bring much attention and people will usually accept it anyway if there are no objection before that. It's much better to just introduce functionality and wait a week or so if anyone has an objection. If there is no objection, then I believe it should be fine to merge. Cheers Jakub
