> -----Oorspronkelijk bericht----- > Van: Rasmus Schultz [mailto:ras...@mindplay.dk] > Verzonden: woensdag 28 juni 2017 11:04 > Aan: PHP internals > Onderwerp: [PHP-DEV] Binary (msgpack) serialize/unserialize > 1. adopt msg_pack() and msg_unpack() from the PECL package as standard > functions, or > Hi Rasmus,
We use msgpack for serialization on a high-traffic site and while I stand by our choice for the format, the implementation in the PECL module in my opinion would need to be improved if shipped as part of core PHP. We've seen (and are seeing) our fair share of issues with it. I managed to fix some with my less-than-adequate skills in C and the maintainers have definitely improved the stability recently. But we are for example still hitting some corruption issue with array references on a daily basis. I haven't been able to narrow it down or reliably reproduce. In general I suspect fuzzing the module might yield a bunch of interesting results. Please don't interpret this as a rant on the maintainers effort or skill though, they have way more of both than I do. I'm not a contributor to the PHP internals, I only subscribe to this list to stay up-to-date, but as a heavy user of msgpack in production I felt chiming in with a word of caution would be appropriate given our experience. I definitely like the idea of PHP standardizing on msgpack as its binary serialization format for the same reasons we've decided to use it. (And it'd most likely lead to significant improvement in the reliability of the implementation, which is of course in my own interest. ;) ) Marlies
