On 2 June 2017 at 17:31, François Laupretre <franc...@tekwire.net> wrote: > Hi Dan, > > Thanks for your comments. Both are fixed now. >
Awesome. btw it's my belief that very boring technical discussions about RFC pull requests are best done via the github comments, both to reduce the noise on this list and also so that people are can be precise, as to which line they are talking about. I can't see any other RFCs that had mundane code issues discussed on the list. However as you declined to respond on Github, I'll ask here again: 1) Why is the patch checking for PHP's own version? This doesn't occur anywhere else in the code 2) Why does the patch modify PHP_API_VERSION, which was already modified for PHP 7.2 Additionally, the section for 'Backward Incompatible Changes' has 'None' listed - but then it lists some required modifications in "To Existing Extensions" - won't non-core PHP extensions also be affected by this RFC? cheers Dan -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
