Hi, > -----Original Message----- > From: Anatol Belski [mailto:anatol....@belski.net] > Sent: Monday, February 20, 2017 4:50 PM > To: 'Dmitry Stogov' <dmi...@zend.com>; 'Nikita Popov' <ni...@php.net>; > 'Xinchen Hui' <larue...@php.net>; 'Joe Watkins' <krak...@php.net> > Cc: 'PHP internals list' <internals@lists.php.net> > Subject: RE: [PHP-DEV] Re: Thread safe interned strings > > Hi, > > > > For now, I see one missing part - opcache can't work completely out > > > of the > > box, > > > because its interned string related functions are wrapped with > > > #ifndef ZTS > > > > > Oh, indeed. Getting to this part now then :) > > > > The Opcache support is done now. Additional things that are done > > - some startup/shutdown sequence refactoring was required in zend.c, to > mitigate shutdown issues with Opcache > - CG(zend_string) was removed, instead there is a global variable > - fixed phpdbg integration > > With this, looks like it's ready for the next review round. I'm doing some load > tests in between. > I'm glad to inform, that the interned strings unification patch has reached the stable state now. It can be found under https://github.com/php/php-src/pull/2390 . The tests are successful so far with FCGI and Apache under Linux and Windows. The intention is to merge the patch into master next days. Additional testing would be great to have, of course.
Huge thanks to Dmitry for the valuable support! Regards Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
