> > Isn't the same quoting functionality available via the quote() method? > That's what the PR's tests use. >
> I don't think it's orthogonal. There are various ways to quote strings > and a generic PDO solution should be flexible enough to handle all drivers. > Yes, they fit into the same general topic of string quoting, but I'd assign different levels of importance to national charset literals and alternate delimiters. Not being able to quote national charset literals means you can't produce correctly formed queries with two drivers. My understanding of alternate delimiters is that they make it easier to hand-writing queries. The quote function may not generate the most human-readable queries for some input, but the queries will be valid. There are a couple other complexities for alternate delimiters. Not all databases allow them and the options vary for each. For example, PostgreSQL's only alternative is dollar-quoting[1]. If you think it's important to handle this functionality, I think a separate RFC would be more appropriate. My guess is instance/statement attributes would be the better mechanism to control delimiters and you might want them to be driver-specific. Thanks, Adam --- [1] https://www.postgresql.org/docs/9.2/static/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING
