On Mon, Dec 5, 2016 at 8:02 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > Hi Levi, > > On Tue, Dec 6, 2016 at 11:52 AM, Levi Morrison <le...@php.net> wrote: >>>> These are not consistent with return type checking. This *must* reuse >>>> the error checking that is already in-place and not provide something >>>> new to accomplish the same thing. >>> >>> What do you mean by inconsistent? >> >> We do not use E_RECOVERABLE_ERROR for return type mismatches; we use >> TypeError. That is the inconsistency. > > It depends. Session module uses errors rather than exceptions. Mixing > them is inconsistent for a module. > > I wrote I prefer exceptions and I'll handle error handling issue > (error -> exception) with other RFC during discussion. So don't worry > about it for now.
Currently all return types use TypeError when they do not match. Do not introduce anything different; we do not need any more special cases than we already have. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
