Hi Dmitry,
Dmitry Stogov wrote:
The main API/BC changes implementation:
https://gist.github.com/dstogov/429fcc2ba051fdcf774a310c5d6db00d
All tests passed. Performance is not affected (+1 CPU instruction on each *new*
element insertion)
If it's OK and allowed, after committing this, I'll add few usages of these new
defines for optimization.
All of them are going to be self-containing changes to particular functions
implementation.
These proposed HT_HAS_STRING_KEYS_ONLY() and HT_HAS_LONG_KEYS_ONLY()
macros look pretty useful. My patch to fix up array/object casts'
handling of numeric strings could make use of these, for instance. I
would be glad to see this merged.
Do you think HT_IS_FULLY_PACKED() would benefit from an explanatory comment?
Thanks!
--
Andrea Faulds
https://ajf.me/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
