On 22.07.2016 at 12:28, Nikita Popov wrote: > On Fri, Jul 22, 2016 at 2:28 AM, Nazar Mokrynskyi <na...@mokrynskyi.com> > wrote: > >> I want to bring here question about supporting custom http methods in >> built-in webserver with router script. >> >> The problem is that GET, POST are standard methods and they work fine, >> but for custom methods like XYZ_METHOD_ALSO_ALLOWED webserver responds >> with 501 Not Implemented. >> >> 501 ideally should never happen when router script is used, since it is >> up to router to decide whether it can handle the request or not. >> >> Initial bug report for additional info and references: >> https://bugs.php.net/bug.php?id=72619 >> Sample repository to reproduce an issue: >> https://github.com/nazar-pc/php-bug-72619 >> >> Christoph Michael Becker said on bug tracker that this kind of change >> will probably require an RFC, however for me this appears to be pretty >> minor change that can barely be a breaking change to someone and it >> should even be backported to 7.0/5.6 when/if implemented in 7.1. >> >> I do not code in C/C++, but I can prepare some PHPT tests for this >> feature if someone is willing to help here. > > Agree, I don't see why this would need an RFC. > > I don't see a point in the HTTP request method detection -- in the end, > applications will only be able to handle a small fraction of the request > methods we consider "allowed". so it's not like these checks are in any way > meaningful -- the application layer still has to deal with this itself if > it's actually interested in generating accurate 405 responses. It's a PITA > to keep this list updated (we're pretty bad at this -- we're very out of > sync with the upstream implementation) and prevents use of custom methods.
After re-reading the RFC which introduced the built-in web server[1] (which doesn't even mention HTTP methods), and finding that non-supported methods can't even be properly handled in the router script, I agree that we should change the web server to accept arbitrary methods; if required, a router script can still reject methods that are unsupported by the app. If this would need an RFC? Still not sure, but maybe starting with a PR and awaiting feedback is sensible. [1] <https://wiki.php.net/rfc/builtinwebserver> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
