On 20.07.2016 at 21:29, Pablo Sánchez wrote: > I made a small fix/adjustment to lastInsertId on pdo_pgsql on branch 7.0.9. > It builded ok, there's a PR for it (https://github.com/php/php-src/pull/2014) > and I just wondered about if I should apply it on 7.1.0, 5.6.whatever, and > 5.5.whatevertoo. The point about applying it to 7.1 seems obvious, but > retro adjustments doesn't.
To which branch a PR should be applied to (and ideally developed against) depends whether it is a simple bug fix, a security issue or a new feature, and on the currently supported versions[1]. As this issue appears to be a bug, it should be applied to the PHP-5.6 branch, so please rebase your commits onto this branch (or open a new PR against PHP-5.6). In any way, never base a PR on a revision branch, such as PHP-7.0.9. [1] <http://php.net/supported-versions.php> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
