On 05/11/2016 09:02 AM, Joe Watkins wrote:
Morning Dmitry,
> On the other hand simple string may be parsed into AST with just one
additional call to ast\compile_string().
You're not really suggesting that I write my tools in user land, are
you ? It's me, Joe :)ce
At first days of RFC discussion Sara pointed on over-design regarding AST.
I saw sense in here comments and updated RFC.
I *only* want attributes as they were originally proposed, and I can't
vote to reflect that.
As discussed in private, what I want is attributes, as originally
proposed, and a hookable compiler; Anything else is not good enough.
Personally, I'm for AST as well, but it's possible to get the same power
translating string values of attributes into AST in the hooks.
Thanks. Dmitry.
Cheers
Joe
On Wed, May 11, 2016 at 6:26 AM, Dmitry Stogov <dmi...@zend.com
<mailto:dmi...@zend.com>> wrote:
Hi Joe,
The sense in native support for AST is questionable.
On one hand this allows syntax verification.
On the other hand simple string may be parsed into AST with just
one additional call to ast\compile_string().
Thanks. Dmitry.
------------------------------------------------------------------------
*From:* Joe Watkins <pthre...@pthreads.org
<mailto:pthre...@pthreads.org>>
*Sent:* Wednesday, May 11, 2016 7:46:09 AM
*To:* Björn Larsson
*Cc:* Dmitry Stogov; PHP internals
*Subject:* Re: [PHP-DEV] [RFC] [VOTE] PHP Attributes
Morning Dmitry,
I'm not really happy with the voting options here.
I would not vote in favour of a patch that does not include
support for AST, that's a completely different feature.
As it is, I have to vote yes in favour of AST, but it may be
counted as a vote in favour of attributes without AST ...
This doesn't seem right ... I don't want attributes without
AST, and there is no voting option to reflect that.
Cheers
Joe
On Tue, May 10, 2016 at 11:09 PM, Björn Larsson
<bjorn.x.lars...@telia.com <mailto:bjorn.x.lars...@telia.com>> wrote:
Den 2016-05-11 kl. 00:00, skrev Dmitry Stogov:
On 05/11/2016 12:29 AM, Björn Larsson wrote:
Den 2016-05-10 kl. 20:29, skrev Dmitry Stogov:
Hi internals,
I've started voting on "PHP Attributes" RFC.
https://wiki.php.net/rfc/attributes
In my opinion, "PHP Attributes" might be a smart
tool for PHP extension, but it's not going to be
the end of the world, if we decided to live with
doc-comments only.
Thanks. Dmitry.
Thanks for the good work. Regarding naming, I googled
"PHP attributes" vs "PHP annotations" and looking at the
result, my view is that that Annotation is a better naming
then Attributes. Any hope in changing it?
The more I listen to arguments of adepts of existing PHP
annotation systems, the more I think, that "PHP
attributes" is the right name for this proposal.
This feature is not just for PHP annotation systems.
Thats a fair point, so Annotation it's not. Still, when I hear PHP
attributes I associate it with class / function attributes. Maybe
just a question getting used to the naming. Hm, wonder if PHP
directives could have been an option?
Regards //Björn
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
<http://www.php.net/unsub.php>
