On Sun, 24 Apr 2016 at 01:25 Davey Shafik <da...@php.net> wrote: > Hi Pierrick, > > This should be in master for 7.1, alongside my RFC'ed patch for server push > support.
I don't see why the additional constants that don't have a direct dependency on your server push patch can't be committed to 7.0 as well. The patch is pretty non-invasive. The patch should hit in 7.1 but it has been requested that tests be added — > and we can't add tests with a server push supporting HTTP/2 server against > which to push. > The only new logic seems to be around CURLMOPT_PIPELINING_*_BL and CURLOPT_STREAM_DEPENDS(_E). I don't know what these do, are they related to server push? Is it possible to add deterministic tests for them? Maybe in 7.1 we could bump the minimum version of cURL required too. #ifdef version checks going back over 12 years seems unnecessary :)
