On 21.03.2016, at 19:41, Anatol Belski <anatol....@belski.net> wrote:
> I've just pushed a fix for this issue, could you please check? A global
> stack space
> Is used in a thread safe manner. I was first setting max to 256K, then
> decreased it
> To 64K for now. My tests on Linux and Windows show your snippet passing,
> Travis is good as well.

Just tested; that fix works for my specific test case, thanks!

However, if I just increase the size of the JSON by adding a bunch of package 
definitions, it starts failing again, so this really is just a temporary 
band-aid, and we should consider falling back to retrying without JIT, or 
switching that off by default in php.ini.

The particular composer.json I showed is generated on deploy based on a 
customers' composer.lock (to correctly resolve PHP versions and extensions to 
be installed), and there will be a day when a customer with more dependencies 
comes along (or maybe that's already happened and they just have not filed a 
ticket), which means the 64k again won't be enough.

My workaround for now is to disable pcre.jit via php.ini, but maybe that really 
should be the default.

Regards,

David


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to