On 20.03.2016, at 20:50, Jakub Zelenka <bu...@php.net> wrote: > > Hi, > > I just wanted to send a quick update about my recent work on openssl ext in > case someone else wanted to start something similar so we don't have a > wasted effort on that. :) > > 1. Error queueing > > I'm more or less done with a patch for error storing and clearing OpenSSL > error queue: > > https://github.com/php/php-src/compare/PHP-7.0...bukka:openssl_error_store
Good stuff! Just FYI, there has been decent progress on the discussion around how to make libpq behave better with openssl errors (that's what I think prompted this change originally by way of a ticket); looks like that'll land in the next point release(s). But since other extensions' libs may also use openssl, the same issue can arise again anytime, so storing the errors ourselves on the PHP side is a great change that fixes all (well, most of) those potential issues in one sweep. > I have been slowly working on a more complete test for openssl_error_string > that will cover most real error cases. There is still quite a lot of work > that I need to do but the incomplete test can be seen here: > > https://github.com/bukka/php-util/blob/master/tests/openssl/openssl_error_string_basic.phpt > > The idea is that I would like to create a PR against 7.0 after I'm happy > with that test so it can be tested by others and then merged. Then I plan > to merge the AEAD work that is complete but overlaps slightly with this one > so I want to merge it after that... Any plans to port that back to 5.6 as well? I'd really love to see that, considering how it fixes real issues in the wild, and how long the security fix phase for 5.6 will be. > 2. OpenSSL 1.1 port > > I have got a port of the extension to work on OpenSSL 1.1. There has been > quite a bit of changes mainly due to the fact that most structures are now > opaque (but also some other changes) I assume 1.0.whatever-is-in-ubuntu will remain usable? Or do we plan on requiring 1.1 in, say, 7.1? Thanks for all your hard work on this Jakub! David -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
