You are right about the error. Thanks for checking.
________________________________ From: Michael Wallner <mike.php....@gmail.com> on behalf of Michael Wallner <m...@php.net> Sent: Thursday, February 25, 2016 13:53 To: Dmitry Stogov Cc: internals@lists.php.net; Hynek Bartoš Subject: Re: [PHP-DEV] unpack() I think the requested feature may be really useful. And the implementation is really simple https://gist.github.com/dstogov/edbb1efcd1e9701e75ab There seems to be a typo at https://gist.github.com/dstogov/edbb1efcd1e9701e75ab#file-unpack-diff-L23 where ‘&&’ should be ‘||’ in the ‘if’ condition. I think, committing this into master doesn't require RFC and voting. Anyone objects? +1 Regards, Mike
