On Wed, Jan 27, 2016 at 1:03 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > Hi all, > > This bug comes to my attention. > https://bugs.php.net/bug.php?id=67383 > > This report includes patch that prevents file descriptor leaks. > https://bugs.php.net/patch-display.php?bug_id=67383&patch=SOCK_CLOEXEC-and-FD_CLOEXEC&revision=latest > > There may be cases that CLOEXEC cannot be applied blindly, but it > seems this fixes lots of bugs including very old bugs. > Why this patch is not merged and closed? > > Regards, > > -- > Yasuo Ohgaki > yohg...@ohgaki.net > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
Hi, Great catch. We already have many CLOEXEC, but we seem to be missing lots of them. There is a note however, in bug ticket 67383, about a problem in FPM with CLOEXEC, which should be qualified and addressed. Just don't apply blindly the patch. Julien.Pauli -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
