Hi Anatol, On Wed, Jan 27, 2016 at 5:06 PM, Anatol Belski <anatol....@belski.net> wrote: > Thanks for all the investigation (as well Remi, Stas and everyone). At first > glance last week, as for me, it looked like OK to keep at least the 7.0 part, > as the breach was only concerning the unit tests but unlikely the actual web > functionality. While it is good to have improvements and hardening on the > unclean behaviors, the area is critical and should be kept stable in stable > branches. Right now, it seems that the patch can have unexposed impacts. > > I would like also to remind that we're now quite short in time as finals are > planned for the next week. With this in mind, IMHO it's better to play safe > and revert 5.6 and 7.0 to the previous state before this change. Or at least, > don't release these patches in the upcoming finals, but keep improving and > fixing BC breaches in dev branch and re-evaluate the status in the next > possible RC.
Reported unit test failures were test code is finding bug fix logic changes. There are missing "if" for transid, but other than this, these changes are valid and correct. However, as a user stand point view, it's frustrating unit tests fails on new minor version, even if it is due to proper fixes. I agree to postpone the fix to next minor version up. Shall I revert my patches now? Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
